treeview: Don't popup a search dialog for keypresses that close it
authorBenjamin Otte <otte@redhat.com>
Thu, 13 Mar 2014 00:57:29 +0000 (01:57 +0100)
committerBenjamin Otte <otte@redhat.com>
Thu, 13 Mar 2014 01:02:50 +0000 (02:02 +0100)
That doesn't make sense.
And it causes issues, because when holding down the tab key, we
show/hide a lot of windows and cause a lot of map/unmap events that
stall the event pipeline.

gtk/gtktreeview.c

index 2776ceab2d3a0214767c9d628b33b95a63893a68..c8824956949e480f770c48f23908bace5359b9ac 100644 (file)
@@ -5918,7 +5918,8 @@ gtk_tree_view_key_press (GtkWidget   *widget,
    * the typeahead find capabilities. */
   if (gtk_widget_has_focus (GTK_WIDGET (tree_view))
       && tree_view->priv->enable_search
-      && !tree_view->priv->search_custom_entry_set)
+      && !tree_view->priv->search_custom_entry_set
+      && !gtk_tree_view_search_key_cancels_search (event->keyval))
     {
       GdkEvent *new_event;
       char *old_text;